Support Env-based SDP part 3: Replace symth selector to label based#563
Open
ninjadq wants to merge 4 commits intoAzure:mainfrom
Open
Support Env-based SDP part 3: Replace symth selector to label based#563ninjadq wants to merge 4 commits intoAzure:mainfrom
ninjadq wants to merge 4 commits intoAzure:mainfrom
Conversation
…dd corresponding tests
ninjadq
changed the title
- Introduced ResolvedSynthName in SimplifiedStatus to track the synthesizer used for composition. - Updated various controllers to utilize the new synthesizer resolution method. - Modified tests to validate the correct population of ResolvedSynthName and its impact on composition behavior. - Improved error handling for synthesizer retrieval based on label selectors.
ninjadq
force-pushed
the
replace_symth_selector_to_label_based
branch
from
1740931 to
f96737b
Compare
Since no composition controller runs in the tests, SimplifiedStatus is never populated, resolvedSynthName is always "", and every composition is skipped. Fix Strategy: Register the Composition Controller in Tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance synthesizer resolution and status tracking